BLIP-Cpp icon indicating copy to clipboard operation
BLIP-Cpp copied to clipboard

Better failure reporting.

Open bmeike opened this issue 6 years ago • 0 comments

This code: https://github.com/couchbaselabs/BLIP-Cpp/blob/0a6346a133860967b4492e6e731843ae9b453587/src/websocket/WebSocketProtocol.hh#L413 ... silently force-closes the connection on failure. It provides the client with absolutely no information about why it is doing so.

The code should at least log the problems (separately).

Better still, it should supply an error to to the client close method, giving the reason for the problem (and, probably, suggesting ProtocolType.BYTE_STREAM)

bmeike avatar Feb 20 '19 21:02 bmeike