couchbase-net-client icon indicating copy to clipboard operation
couchbase-net-client copied to clipboard

Published 20 hours ago • verified publisher icon couchbase

Pull TermQuery fix forward from 2.7 SDK

Open nekstrom opened this issue 2 years ago • 5 comments

Changed TermQuery to no longer export "fuzziness" or "prefix_length" in JSON sent to server when values are 0. This fixes an issue in Couchbase 6.5 Server FTS code which fails when values of 0 are provided for "fuzziness" or "prefix_length". See https://github.com/couchbase/couchbase-net-client/commit/62756837d7a029ce0b762e3edef29c4600b7b6a4 which fixed this issue in the 2.7 SDK.

nekstrom avatar Jul 13 '22 18:07 nekstrom

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: 5039*******[email protected]********thub.com

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

cb-sdk-robot avatar Jul 13 '22 18:07 cb-sdk-robot

@nekstrom

Thanks for the commit! I don't see it in gerrit (our code review system), likely because your previous commit was using a different email than the one used for this commit.

If you login into gerrit and update your profile with this email 5039*******[email protected]********thub.com, it should be automatically pushed to gerrit.

Jeff

jeffrymorris avatar Jul 15 '22 21:07 jeffrymorris

Your changes (commit: 9d8b08782983093c2f769571ec1921a8997fd3dd) have been pushed to the Couchbase Review Site: http://review.couchbase.org/177638

::SDKBOT/PR:created

cb-sdk-robot avatar Jul 16 '22 01:07 cb-sdk-robot

@jeffrymorris I updated the commit author to match, and it looks like the cb-sdk-robot pushed it to Gerrit. Let me know if there are other issues.

nekstrom avatar Jul 16 '22 01:07 nekstrom

Thanks @nekstrom, its now in gerrit! Myself or someone else from Couchbase will review it and it will be included in the next patch release.

Jeff

jeffrymorris avatar Jul 16 '22 03:07 jeffrymorris

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged

cb-sdk-robot avatar Sep 19 '22 12:09 cb-sdk-robot

Thanks!

jeffrymorris avatar Sep 20 '22 17:09 jeffrymorris