couchbase-lite-core icon indicating copy to clipboard operation
couchbase-lite-core copied to clipboard

Published 20 hours ago • verified publisher icon couchbase

CBL-5634 (Fix): ReplacementRev puller enhancement

Open callumbirks opened this issue 1 year ago • 3 comments

callumbirks avatar Apr 30 '24 14:04 callumbirks

Turns out I had misread the spec before. "replacedRev" contains the revID of the rev we originally requested. "rev" still contains the revID of the rev we are being sent, whether or not it is a replacementRev. See the testing I've done for this in this PR: #2021

callumbirks avatar Apr 30 '24 14:04 callumbirks

Code Coverage Results:

Type Percentage
branches 69.87
functions 80.3
instantiations 36.84
lines 80.32
regions 76.86

cbl-bot avatar Apr 30 '24 17:04 cbl-bot

Whoops I caught my keyboard and it assigned CBL-bot somehow 😆

callumbirks avatar May 03 '24 08:05 callumbirks

@pasin I've added a log. It will be for example

Received revision 'doc1' #2-ff (seq '1') (replaced rev #1-ff)

callumbirks avatar May 07 '24 09:05 callumbirks