coturn icon indicating copy to clipboard operation
coturn copied to clipboard

Redis pubsub: no /traffic messages, but plenty of __XXX__

Open OrangeDog opened this issue 8 years ago • 5 comments

According to schema.stats.redis there are supposed to be messages published with keys ending /traffic, but I see no such thing in practice. What is seen, however, are messages with the key __XXX__ and the message __YYY__, which look distinctly like someone forgot to fill in a placeholder...

$ redis-cli
127.0.0.1:6379> select 1
OK
127.0.0.1:6379[1]> psubscribe *
Reading messages... (press Ctrl-C to quit)
1) "psubscribe"
2) "*"
3) (integer) 1
1) "pmessage"
2) "*"
3) "turn/realm/local/user/test/allocation/000000000000000012/status"
4) "new lifetime=777"
1) "pmessage"
2) "*"
3) "__XXX__"
4) "__YYY__"
1) "pmessage"
2) "*"
3) "__XXX__"
4) "__YYY__"

OrangeDog avatar Jun 02 '17 15:06 OrangeDog

No, those _XXX and YYY messages are not from coturn. Looks like your redis somehow truncating the full message.

On Fri, Jun 2, 2017 at 8:32 AM, James Howe [email protected] wrote:

According to https://github.com/coturn/coturn/blob/master/turndb/ schema.stats.redis there are supposed to be messages published with keys ending /traffic, but I see no such thing in practice. What is seen, however, are messages with the key XXX and the message YYY, which look distictly like someone forgot to fill in a placeholder...

$ redis-cli127.0.0.1:6379> select 1 OK 127.0.0.1:6379[1]> psubscribe * Reading messages... (press Ctrl-C to quit)

  1. "psubscribe"
  2. "*"
  3. (integer) 1
  4. "pmessage"
  5. "*"
  6. "turn/realm/local/user/test/allocation/000000000000000012/status"
  7. "new lifetime=777"
  8. "pmessage"
  9. "*"
  10. "XXX"
  11. "YYY"
  12. "pmessage"
  13. "*"
  14. "XXX"
  15. "YYY"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coturn/coturn/issues/150, or mute the thread https://github.com/notifications/unsubscribe-auth/AFq2UBIejLIMxcqN4z-uyBRP9SsIj47tks5sACsogaJpZM4NucHq .

mom040267 avatar Jun 04 '17 20:06 mom040267

Are you sure about that: https://github.com/coturn/coturn/blob/4.5.0.6/src/apps/relay/netengine.c#L1555

OrangeDog avatar Jun 05 '17 06:06 OrangeDog

Hm... that looks like a debug output. I'll check that.

On Sun, Jun 4, 2017 at 11:59 PM, James Howe [email protected] wrote:

Are you sure about that: https://github.com/coturn/ coturn/blob/4.5.0.6/src/apps/relay/netengine.c#L1555

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coturn/coturn/issues/150#issuecomment-306117767, or mute the thread https://github.com/notifications/unsubscribe-auth/AFq2UA5R-d85VJFb7NkKCyvYdCUU8pIyks5sA6c4gaJpZM4NucHq .

mom040267 avatar Jun 05 '17 07:06 mom040267

Debian 8, installed coturn and libhiredis0.10 Same problem.

Only /status messages in redis-cli, not /traffic. And ___XXX__ and ___YYY___ messages

Its problem with package or something else? @mom040267, can you help me?

strannick-ru avatar Aug 09 '17 07:08 strannick-ru

Those definitely look like placeholders for some events but not implemented - starting from the original source code import I suggest removing this code as it does nothing and only adds load on redis

(and as my personal opinion - redis is not a monitoring system and should not be used as such. prometheus is much better interface and if anything - it is worth investing time improving prometheus metrics)

@ggarber what do you think? Might also improve #913 just a tiny little bit

eakraly avatar Aug 22 '22 23:08 eakraly

#427 stays for the traffic publishing

eakraly avatar Oct 06 '22 23:10 eakraly