jekyll-theme-chirpy icon indicating copy to clipboard operation
jekyll-theme-chirpy copied to clipboard

changed variable heading in module.scss

Open renanduart3 opened this issue 3 years ago • 0 comments

Description

The button of theme selection (light and dark) doesn't changing the heading post color (because they are inside a tag link 'a'), causing visual problems with light and dark theme, depeding the color wich is configured.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How has this been tested

Just run the project and see the color of the heading posts changing according to the heading pattern color. Before, the heading in scss module.scss doesn't aply the color in the subsequents heading links.

  • [x] I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • [x ] I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system:
  • Ruby version: ruby 2.7.0p0
  • Bundler version: Bundler version 2.3.18
  • Jekyll version: st | grep " jekyll " * jekyll (4.2.2)

Checklist

  • [x] I have performed a self-review of my code
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

renanduart3 avatar Jul 29 '22 21:07 renanduart3