jekyll-theme-chirpy icon indicating copy to clipboard operation
jekyll-theme-chirpy copied to clipboard

feat: let any layout able to be homepage

Open bonjour-py opened this issue 1 year ago • 2 comments

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Improvement (refactoring and improving code)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

Description

  • separate posts from the homepage:
    • other suffixes of index is able to use
    • now any layout can be homepage by change page.layout of index.html
    • add posts layout same as the old home layout
    • retained the home layout for compatibility

Additional context

Known issues:

  • non index posts can not be paginated
    • neither of jekyll-paginate or jekyll-paginate-v2(production) is able to work it out

Todo:

  • remove home layout
    • a breaking change

bonjour-py avatar Jan 12 '24 17:01 bonjour-py

Thanks for reaching out! Dynamic tabs is something that had been planned before, and this feature is not very urgent. And you've submitted a lot of changes that I haven't had time to review yet.

As you said, this is a breaking change, so it should be moved forward slowly and carefully.

cotes2020 avatar Jan 13 '24 14:01 cotes2020

It's not recommended to use page.layout == * as condition if you want to support any layouts. It's better to include needed pages in the specific layouts.

JinchaoLove avatar Jan 21 '24 02:01 JinchaoLove

there are many commits behind master. try to get a more fluently change

bonjour-py avatar Mar 22 '24 07:03 bonjour-py