Costin Manolache

Token buckets are standard for implementing rate limiting. The question I suspect is if they should be exposed as part of the API, and if users should be expected (...

Can we start fixing the issue instead of making it worse ? Users don't enjoy an API where each team uses a different keyword. On Tue, Oct 20, 2020 at...

Do we have any bugs in validation ? Many of the errors seem to be things that shouldn't have passed validation. For dynamic errors - like pod missing proxy -...

On Mon, Dec 7, 2020 at 4:47 AM Zhonghu Xu wrote: > *@hzxuzhonghu* commented on this pull request. > ------------------------------ > > In networking/v1alpha3/virtual_service.proto > : > > > +...

On Mon, Dec 7, 2020 at 4:20 AM Zhonghu Xu wrote: > *@hzxuzhonghu* commented on this pull request. > ------------------------------ > > In mesh/v1alpha1/config.proto > : > > > @@...

On Mon, Dec 7, 2020 at 4:20 AM Zhonghu Xu wrote: > *@hzxuzhonghu* commented on this pull request. > ------------------------------ > > In mesh/v1alpha1/config.proto > : > > > @@...

We can discuss in the networking meeting, currently at 9 PST. PST 17:00 sounds good too - maybe we should discuss moving the networking meeting at this time if it...

I'm not sure how much we broke. In-cluster traffic should be mostly fine - the other sidecars have the safe cyphers anyways. This API is only relevant for legacy/special destinations...

I am ok with adding it to DR, but as a 'allow insecure ciphers' or similar option - instead of asking users to list each of the weird names. On...

If low level cipher config is desired - we still have EnvoyFilter, and if we find a lot of users need this we can add the array field to DR...