Costin Manolache
Costin Manolache
On Thu, May 2, 2024 at 9:02 AM Ben Leggett ***@***.***> wrote: > Can you add a release note file? > > Also explain why use daemonset vs pod level...
> > + # Custom labels on Daemonset level, for eg - FinOps/teams labels > + labels: {} > + # team-owner: finops > + > + # Custom labels...
> @ericvn WDYT of this? > > This puts a dependency on buf.build servers at build time (like we depend on the golang module proxy) Do we still support offline...
Offline usage: "I am on an airplane" or "isolated environment is required for security reasons". I assume the buf.build servers are only used in 'make generate' - so not a...
That's a bit better - but still something that should be in the PR description. I assume someone modifying the proto sources is less critical - at worse they may...
And for my understanding - by 'pull from buf instead of checked into git' - do you mean we make http requests on each "make gen" to some server, or...
No, John mentioned earlier that it's not using the buf servers at all. If that's correct, and we are getting some stuff from their git repos - I have no...
Well - we do need better PR descriptions... I don't know what it's using - it's opaque code. My first thought was that it's going to Jia Tan's server -...
I agree - while we need to start paying more attention to those things, I don't think this PR or using buf is a real problem - or we need...