Cosmin Popovici

Results 167 comments of Cosmin Popovici

Hmm so actually, it does work. The problem I had was with an array of objects, and that can be done like this: ```js const items = [ { title:...

Thanks for the detailed report Joey, looks like a bug indeed. Will look into it and fix it 👍

This will be fixed in 5.0.0, unfortunately I don't have enough time to also fix it in v4.x sorry!

Right, so the problem is here: https://github.com/maizzle/framework/blob/659e2a47ed2584153fd4fbc93d176387bac885ad/src/generators/output/to-disk.js#L239 We should just `throw` in that case, i.e.: ```diff - .catch(error => spinner.warn(error.message)) + .catch(error => { + throw error + }) ```...

How would this work? Data URI?

Hi there, would it be feasible to just remove the selectors that have been successfully inlined instead? From both the CSS and the HTML `class` attrs - ideally you'd only...

Juice only handles CSS syntax, anything else like SASS should be first compiled to CSS.

Fair enough, I've reopened the issue. Feel free to work on a PR (with tests and documentation) that implements support for this in Juice, I will be happy to review...

We could also take the opportunity to rename the function if there's a better/shorter name than `generatePlaintext`.

You can already do `render(html, {plaintext: true})`, the `plaintext` method is for cases where you might need to only generate plaintext and not compile any templates.