themis icon indicating copy to clipboard operation
themis copied to clipboard

Add pythemis_uninstall target to Makefile. Fixes #948

Open sashimanu-san opened this issue 3 years ago • 5 comments

Added a pythemis_uninstall target to Makefile.

Checklist

sashimanu-san avatar Sep 23 '22 14:09 sashimanu-san

does it work? :D

vixentael avatar Sep 23 '22 14:09 vixentael

does it work? :D

it does indeed!

sashimanu-san avatar Sep 23 '22 14:09 sashimanu-san

unrelated to the PR

look, @ilammy oh no, rust has updated? or clippy? rust tests are failing 😱

error: unnecessary parentheses around match arm expression
   --> src/wrappers/themis/rust/src/error.rs:252:73

vixentael avatar Sep 23 '22 15:09 vixentael

As a long-term solution, we should think about migrating from setup.py completely to... well... whatever Python community considers the "modern way" this year. The one we use has been deprecated for about 10 years. With Guido stepping down, I wouldn't be surprised if they rip it out completely one day.

For python_install and python_uninstall, I think it would be acceptable to add a requirement to have pip installed locally, then do what RbThemis does in its targets: build a real package like you'd install from the repos and install that one locally. Not in this PR, a separate one would be nice. Gotta weight compatibility concerns separately.

ilammy avatar Sep 24 '22 14:09 ilammy

@sashimanu-san could you please take a look at the discussion?

vixentael avatar Oct 09 '22 22:10 vixentael