cospectrum
cospectrum
We have KAZE in the roadmap https://github.com/image-rs/imageproc/issues/340. But I'm not sure about the `pinhole camera` and related stuff, @theotherphil what do you think?
"into" usually used for owned/moved values. For mutation, imageproc prefers "mut" postfix currently, and I think there is even a macro to generate documentation for such "mut" functions. But that's...
Tests would be good
I know, it's hard. Maybe you can start with property testing just to detect panics and limitations, you can introduce invariants. For example, center should be in bounds. Maybe rotate...
You can try to increase epsilon, maybe it will help. Also, for image comparison you can create dedicated function(s), so you will not violate "DRY". It can be any perceptual...
The difference between "no crop" rotation and simple rotation is that the watermark should always be in the output, so such a test would be especially useful.
`elephant_rotate_no_crop_bicubic_rgba.png` is incorrect
Maybe let's introduce only 1 new public function? Other functions are not particularly relevant to the feature. I just want to avoid breaking API in the future.
Not because I'm against those functions. I just think that every public function deserves a separate review from several individuals.
Ok, there's only 1 thread left about the `default` value. Perhaps the output should be created as `let out = Image::from_pixel(out_w, out_h, default);`. I don't remember the exact implementation of...