air icon indicating copy to clipboard operation
air copied to clipboard

Worn if tmp is dot

Open musinit opened this issue 4 years ago • 6 comments

Also added warning log with red default color

musinit avatar Apr 16 '20 11:04 musinit

Are PR's actually accepted or responded with, here?

udaya2899 avatar Jul 02 '20 14:07 udaya2899

Looks like they don't accept for a while

musinit avatar Jul 02 '20 14:07 musinit

i think use warning is a not better way. because you also warning this message and user know this problem they use ctrl + c to stop the process and his project Always will be clean. as I think you should raise a err and stop the project!

xiantang avatar Jul 24 '20 15:07 xiantang

@musinit

xiantang avatar Jul 24 '20 15:07 xiantang

pr is welcome!

xiantang avatar Jul 24 '20 15:07 xiantang

I agree with @xiantang. Data loss should not be acceptable at all. Instead of a warning, the best option is to print an error message and exit the application immediately, without triggering the cleanup.

HeCorr avatar Mar 13 '21 15:03 HeCorr