air icon indicating copy to clipboard operation
air copied to clipboard

chore: bump Go to 1.22

Open troutowicz opened this issue 1 year ago • 1 comments

troutowicz avatar Feb 12 '24 16:02 troutowicz

Hey @cosmtrek - a new release supporting the latest version of go would be reaallyyy nice. Air is preventing my team from bumping our projects to 1.22 (since it breaks our engineers' local dev worklows).

adrianosela avatar Feb 17 '24 21:02 adrianosela

@troutowicz Hi, could you fix the tests? Thanks

cosmtrek avatar Feb 18 '24 06:02 cosmtrek

Hey @cosmtrek, removed that second commit. Will address GH action config another time.

troutowicz avatar Feb 18 '24 15:02 troutowicz

Hey @cosmtrek - a new release supporting the latest version of go would be reaallyyy nice. Air is preventing my team from bumping our projects to 1.22 (since it breaks our engineers' local dev worklows).

We were having the same issue. However, for future blocks, I think setting a newer toolchain will address local dev workflows.

go 1.21

toolchain go1.22.0

https://go.dev/blog/toolchain

troutowicz avatar Feb 18 '24 17:02 troutowicz

Hey @cosmtrek -- sorry to bother again. Can we merge this?

adrianosela avatar Feb 20 '24 20:02 adrianosela

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5c81890) 69.22% compared to head (483f6ce) 65.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   69.22%   65.28%   -3.94%     
==========================================
  Files           9       10       +1     
  Lines        1082     1158      +76     
==========================================
+ Hits          749      756       +7     
- Misses        253      324      +71     
+ Partials       80       78       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 21 '24 03:02 codecov[bot]