air icon indicating copy to clipboard operation
air copied to clipboard

Published 20 hours ago • verified publisher icon cosmtrek

feat: Make include_file overrule include_ext, fixes: #350, base_on: #358

Open zhb127 opened this issue 1 year ago • 7 comments

Fixes: #350

Base on: #358

I don't know, why marked #358 PR as draft?

Just fix code by #358 PR author's comments. then create new PR.

zhb127 avatar Apr 21 '23 03:04 zhb127

Please add "Fixes: https://github.com/cosmtrek/air/issues/350" to your comment.

silverwind avatar Apr 21 '23 06:04 silverwind

Please add "Fixes: #350" to your comment.

OK

zhb127 avatar Apr 21 '23 06:04 zhb127

Bump, would love to see this merged.

silverwind avatar Sep 05 '23 20:09 silverwind

Just to notify, I personally want to see this merged

nmfzone avatar Sep 12 '23 15:09 nmfzone

Bump - would love to see this merged as well, seems it's been hanging for a while

park-jemin avatar Nov 06 '23 18:11 park-jemin

You should also include this change to actually test the changed functionality:

https://github.com/cosmtrek/air/pull/358/files#diff-c484509c25b7c8e4df331c9aefcbb49e43881a9a57c201a4491a4b7b61a72acb

silverwind avatar Feb 02 '24 11:02 silverwind

You should also include this change to actually test the changed functionality:

https://github.com/cosmtrek/air/pull/358/files#diff-c484509c25b7c8e4df331c9aefcbb49e43881a9a57c201a4491a4b7b61a72acb

thx, The test code has been added.

zhb127 avatar Feb 02 '24 14:02 zhb127