air icon indicating copy to clipboard operation
air copied to clipboard

Preserve runtime arguments when using `full_bin`

Open cinaglia opened this issue 2 years ago • 2 comments

Fixes https://github.com/cosmtrek/air/issues/320.

This PR fixes an issue where runtime args were being ignored when specifying full_bin as opposed to bin properties in the config.

cinaglia avatar Aug 11 '22 19:08 cinaglia

Codecov Report

Merging #321 (ca86047) into master (4515837) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   69.16%   69.04%   -0.12%     
==========================================
  Files           7        6       -1     
  Lines         960      924      -36     
==========================================
- Hits          664      638      -26     
+ Misses        225      218       -7     
+ Partials       71       68       -3     
Impacted Files Coverage Δ
runner/config.go 75.11% <100.00%> (ø)
runner/engine.go 63.08% <0.00%> (-0.53%) :arrow_down:
runner/util_darwin.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 12 '22 03:08 codecov[bot]

Is there anything I could do to help this cross the finish line? Thanks!

I assume the build error is expected? I have seen a couple of other PRs with this same issue.

cinaglia avatar Sep 06 '22 12:09 cinaglia

I'm intend to merge the PR, let me find why the pipeline is failed

xiantang avatar Oct 24 '22 06:10 xiantang