cosmoscout-vr
cosmoscout-vr copied to clipboard
Simple-Objects Plugin
This pull request contains the new csp-simple-objects plugin with a readme. With this it is possible to load glTF 3D models, place them on celestial bodies, rotate and move each object as desired.
Things that still need to be improved:
- [ ] Replace the rotation input boxes and the button next to them with three Euler angle sliders. This means that conversion to a quaternion is still necessary.
- [ ] The fly to object functionality is not implemented yet, but should be trivial.
- [ ] CosmoScout VR crashes when entering a non-existent anchor name in the editor input field.
- [ ] It's likely that there are other bugs that I haven't found yet.
Pull Request Test Coverage Report for Build 2889928608
- 0 of 287 (0.0%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.05%) to 2.942%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
plugins/csp-simple-objects/src/logger.cpp | 0 | 3 | 0.0% |
plugins/csp-simple-objects/src/utils.cpp | 0 | 18 | 0.0% |
plugins/csp-simple-objects/src/SimpleObject.cpp | 0 | 95 | 0.0% |
plugins/csp-simple-objects/src/Plugin.cpp | 0 | 171 | 0.0% |
<!-- | Total: | 0 | 287 |
Totals | |
---|---|
Change from base Build 2696156115: | -0.05% |
Covered Lines: | 491 |
Relevant Lines: | 16691 |
💛 - Coveralls
I played around with the plugin! Most of the time, it works flawlessly. However, in addition to the list of issues you posted above, I discovered some further things:
- Saving a scene does not seem to work.
- Place some objects.
- Call
CosmoScout.callbacks.core.save("test.json")
- Restart CosmoScout VR
- Call
CosmoScout.callbacks.core.load("test.json")
- The previously placed objects are not there.
- The sun light direction is not updated
- I think basically something like this is missing.
- There seems to be a minimum distance for the object location picking to be available. For me, this is a bit confusing. Is there a reason for it not being always available?
- Sometimes, objects become transparent. They may actually not be transparent but the draw order could be wrong. This is not-so-easy to reproduce, however, here's a possibility:
- Start cosmoscout with the example configuration (avocado & curiosity on Mars).
- Uncheck Advanced Settings -> Atmospheres -> Enabled. This will make the issue easier to spot.
- Fly to Earth and land on the surface, let's say in Italy.
- Use the edit button and then the surface picking to place curiosity somewhere in Italy.
- You may have to adjust the size to see it, let's insert 100.
- Observe the stars through curiosity :wink:
- If you save the object, the issues persists. However, if you edit it again, it looks fine. But only until you save it again.