cosmoscout-vr icon indicating copy to clipboard operation
cosmoscout-vr copied to clipboard

Simple-Objects Plugin

Open carlobrok opened this issue 2 years ago • 2 comments

This pull request contains the new csp-simple-objects plugin with a readme. With this it is possible to load glTF 3D models, place them on celestial bodies, rotate and move each object as desired.

Things that still need to be improved:

  • [ ] Replace the rotation input boxes and the button next to them with three Euler angle sliders. This means that conversion to a quaternion is still necessary.
  • [ ] The fly to object functionality is not implemented yet, but should be trivial.
  • [ ] CosmoScout VR crashes when entering a non-existent anchor name in the editor input field.
  • [ ] It's likely that there are other bugs that I haven't found yet.

carlobrok avatar Aug 19 '22 13:08 carlobrok

Pull Request Test Coverage Report for Build 2889928608

  • 0 of 287 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 2.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-simple-objects/src/logger.cpp 0 3 0.0%
plugins/csp-simple-objects/src/utils.cpp 0 18 0.0%
plugins/csp-simple-objects/src/SimpleObject.cpp 0 95 0.0%
plugins/csp-simple-objects/src/Plugin.cpp 0 171 0.0%
<!-- Total: 0 287
Totals Coverage Status
Change from base Build 2696156115: -0.05%
Covered Lines: 491
Relevant Lines: 16691

💛 - Coveralls

coveralls avatar Aug 19 '22 18:08 coveralls

I played around with the plugin! Most of the time, it works flawlessly. However, in addition to the list of issues you posted above, I discovered some further things:

  • Saving a scene does not seem to work.
    1. Place some objects.
    2. Call CosmoScout.callbacks.core.save("test.json")
    3. Restart CosmoScout VR
    4. Call CosmoScout.callbacks.core.load("test.json")
    5. The previously placed objects are not there.
  • The sun light direction is not updated
  • There seems to be a minimum distance for the object location picking to be available. For me, this is a bit confusing. Is there a reason for it not being always available?
  • Sometimes, objects become transparent. They may actually not be transparent but the draw order could be wrong. This is not-so-easy to reproduce, however, here's a possibility:
    1. Start cosmoscout with the example configuration (avocado & curiosity on Mars).
    2. Uncheck Advanced Settings -> Atmospheres -> Enabled. This will make the issue easier to spot.
    3. Fly to Earth and land on the surface, let's say in Italy.
    4. Use the edit button and then the surface picking to place curiosity somewhere in Italy.
    5. You may have to adjust the size to see it, let's insert 100.
    6. Observe the stars through curiosity :wink:
    7. If you save the object, the issues persists. However, if you edit it again, it looks fine. But only until you save it again.

Schneegans avatar Sep 02 '22 08:09 Schneegans