vuepress-theme-cosmos icon indicating copy to clipboard operation
vuepress-theme-cosmos copied to clipboard

Check deadlinks

Open lovincyrus opened this issue 4 years ago • 2 comments

Check dead links in *.md that cause docs build error

  • ~~https://www.npmjs.com/package/vuepress-plugin-check-md~~
  • ~~https://www.npmjs.com/package/netlify-plugin-checklinks~~
  • ~~https://www.npmjs.com/package/hyperlink~~
  • https://github.com/tcort/markdown-link-check
  • https://github.com/gaurav-nelson/github-action-markdown-link-check

Related:

  1. https://github.com/cosmos/cosmos-sdk/pull/7832
  2. https://github.com/cosmos/vuepress-theme-cosmos/issues/140
  3. https://github.com/cosmos/cosmos-sdk/pull/8353#issuecomment-765638877

Update

  • It's been implemented on https://github.com/cosmos/cosmos-sdk/blob/master/.github/workflows/linkchecker.yml
  • GitHub Action Workflow: https://github.com/cosmos/cosmos-sdk/runs/1745976788?check_suite_focus=true#step:4:1449
  • Broken link https://github.com/cosmos/cosmos-sdk/blob/0.40.0/simapp/simd/cmd/root.go#L99-L121 still go unnoticed
  • Ref: https://github.com/cosmos/cosmos-sdk/pull/8353#issuecomment-765638877

lovincyrus avatar Jan 13 '21 19:01 lovincyrus

Maybe it's necessary to add another workflow to check the deadlinks of the modified files for PRs on top of scanning for deadlinks every 24 hours.

cc: @marbar3778

lovincyrus avatar Jan 23 '21 00:01 lovincyrus

This is possible, I was wondering what is the best way to handle reidrects?

tac0turtle avatar Jun 01 '21 13:06 tac0turtle