scaffold icon indicating copy to clipboard operation
scaffold copied to clipboard

Evidence not included in begin block

Open antho1404 opened this issue 4 years ago • 1 comments

Should Evidence module be included in the SetOrderBeginBlockers?

The evidence module is doing some check on the begin block but SetOrderBeginBlockers reset the list of beginBlocks to apply and the begin block of evidence will never be called.

Am I missing something? Also this might be the case for other modules as well

https://github.com/cosmos/scaffold/blob/8ef28f6f2163841cd5767876604d5b15be7ccc8f/templates/lvl-max/app/app.go.tmpl#L296

antho1404 avatar Jun 03 '20 05:06 antho1404

The other module are registered through the appmodule interface. This will be below with app.SetBeginBlocker(app.BeginBlocker) This is how its done within Gaia, but the sdk simapp is regestering evidence. I will have to double check the reasoning behind this.

tac0turtle avatar Jun 04 '20 07:06 tac0turtle