relayer icon indicating copy to clipboard operation
relayer copied to clipboard

feat: add separate flag for metrics

Open AntiTyping opened this issue 1 year ago • 1 comments

Refactors debug and metrics servers into two separate servers

  • adds --enable-metrics-server
  • uses 127.0.0.1 as the default address for debug and metrics servers
  • uses port 5184 as the default port for metrics server
  • adds metrics-listen-addr setting to config.yaml
  • rly config init will generate the following config
  • renamed api-listen-addr to debug-listen-addr
  • renames --debug-addr to --debug-listen-addr to be consistent with config
global:
    debug-listen-addr: 127.0.0.1:5183
    metrics-listen-addr: 127.0.0.1:5184
    ...
  • [x] manually test the relayer to make sure it works today
  • [x] add unit tests to make sure it works today and in the future

AntiTyping avatar Sep 16 '24 20:09 AntiTyping

Just saying, 9100 is a default port for node_exporter, which is widely used everywhere for HW metrics collection, so it might clash.

freak12techno avatar Sep 16 '24 20:09 freak12techno

Did we still want to ensure backwards compatibility in this PR by adding back the old flags/old fields in the config, and then mark things deprecated for one release?

If not then i think this is mostly ready to merge and we can just cut a new major release

jtieri avatar Oct 17 '24 17:10 jtieri

@jtieri I restored the legacy flags and settings in this commit https://github.com/cosmos/relayer/pull/1504/commits/6cb53dcd407683e39d5fec051156fbaf2779b894

AntiTyping avatar Oct 18 '24 17:10 AntiTyping