ledger-cosmos
ledger-cosmos copied to clipboard
Derivation path generated incorrectly
#156 changed APPPATH from APPPATH = "44'/118'" --path "44'/60'" to:
APPPATH = "44'/118'" "44'/60'"
(ref https://github.com/cosmos/ledger-cosmos/pull/156/files#diff-0c6c7defde945725f3d878fe20d0866dc29520f5f3816ff91ca56df2211e5451L73)
This results in installer_*.sh having these lines:
APPPATH="44'/118' 44'/60'"
# ...
python3 -m ledgerblue.loadApp "${LOAD_PARAMS[@]}" --path ${APPPATH} --path "44'/1'"
which produces an error when trying to run since ${APPPATH} has a space in it:
loadApp.py: error: unrecognized arguments: 44'/60'
It looks like ledgerblue does not split --path arguments on spaces, so I think the correct fix would be to have a --path for each path.
Thanks @adlerjohn
[!IMPORTANT] This is not a derivation path generated incorrectly, in the sense of affecting key generation or signatures.
This just affects a development installer script that has actually been superseded. I would flag this issue as low priority and mostly cosmetic at this stage. The derivation path prefix here is used to authorize access to path branches in development devices.