interchain-security icon indicating copy to clipboard operation
interchain-security copied to clipboard

nit: better distinguish between `ConsumerValidatorBytePrefix` and `ConsumerValidatorsBytePrefix`

Open insumity opened this issue 1 year ago • 9 comments

Problem

Byte prefixes ConsumerValidatorsBytePrefix and ConsumerValidatorBytePrefix almost have the same name although they're used when storing vastly different things.

This issue is just a reminder to clean up their naming so it's not as confusing.

insumity avatar Jul 23 '24 09:07 insumity

@insumity, I would love to work on this issue. Please let me know if you are accepting open-source contributions.

aditipatelpro avatar Aug 21 '24 03:08 aditipatelpro

@aditipatelpro Sorry for the late reply. We were focusing on the ICS 6.0.0 release and we missed your comment. We are gladly accepting external contributions. Please let us know if you still want to take this over so that I can assign it to you. Thanks.

mpoke avatar Sep 17 '24 09:09 mpoke

@mpoke, I am still excited and available to work on this issue. thank you.

aditipatelpro avatar Sep 22 '24 22:09 aditipatelpro

@aditipatelpro Thanks. I assigned the issue to you. Please let us know if you have any questions.

mpoke avatar Oct 03 '24 08:10 mpoke

@mpoke Was this issue fixed in the ICS 6.0.0 version?

I can't seem to find either ConsumerValidatorsBytePrefix or ConsumerValidatorsBytePrefix in provider/types/keys.go file from 6.0.0 realse onwards.

aditipatelpro avatar Oct 25 '24 03:10 aditipatelpro

@aditipatelpro the way keys are stored got changed a bit. Look for ConsumerValidatorsKeyName and ConsumerValidatorKeyName in keys.go. Follow the flow all the way to the keeper methods.

mpoke avatar Oct 25 '24 12:10 mpoke

@mpoke, thank you for clarifying, I will get started with new key names.

aditipatelpro avatar Oct 25 '24 14:10 aditipatelpro

Hi @mpoke, Unfortunately, I don't have the bandwidth to work on this issue currently. Can you please unassign me from this issue?

aditipatelpro avatar Nov 13 '24 00:11 aditipatelpro

@insumity @mpoke can I work on this issue?

hungdinh82 avatar Feb 25 '25 15:02 hungdinh82