ibc icon indicating copy to clipboard operation
ibc copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

Add proto3 json as ICS 27 encoding type

Open colin-axner opened this issue 2 years ago • 4 comments

See discussion on https://github.com/cosmos/ibc-go/issues/3246 for justification of the addition.

Related issue: #634

colin-axner avatar Jun 21 '23 16:06 colin-axner

@colin-axner, is this still open? I think https://github.com/cosmos/ibc-go/pull/3796 should close this. Or do let me know if anything else needs to be done.

Teja2045 avatar Dec 27 '23 18:12 Teja2045

Yes I believe it is still open unless the specs in this repo have been updated?

colin-axner avatar Mar 11 '24 15:03 colin-axner

Wondering if we need to add this to spec... Currently the spec doesn't really specify any possible encoding formats and seems to leave this to the implementations... what do you think, @AdityaSripal?

crodriguezvega avatar Mar 11 '24 21:03 crodriguezvega

It's not possible to integrate correctly these applications without knowing the expected encoding. My comment here is an example where using proto3 json vs standard json is not compatible

It is a problem that the spec doesn't specify encoding formats

colin-axner avatar Mar 12 '24 15:03 colin-axner