ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Remove the need for simapp in 08-wasm module

Open damiannolan opened this issue 1 year ago • 9 comments

Summary

It should be possible to refactor the tests in 08-wasm such that it does not rely on needing an entire simapp.

We only use a single test chain in 08-wasm and what we depend on mostly is the MockVM implementation. Investigate removal of the simapp in 08-wasm and adapting tests to not depend so heavily on it.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned
  • [ ] Estimate provided

damiannolan avatar Dec 20 '24 15:12 damiannolan

Hi @damiannolan Can I get this one?

duonghb53 avatar Mar 03 '25 07:03 duonghb53

Hey @duonghb53, I'm not longer maintainer on this repo. Maybe @AdityaSripal or @gjermundgaraba can chime in.

damiannolan avatar Mar 03 '25 12:03 damiannolan

Hey @duonghb53, I'm not longer maintainer on this repo. Maybe @AdityaSripal or @gjermundgaraba can chime in.

Thank @damiannolan , @gjermundgaraba can I this one?

duonghb53 avatar Mar 04 '25 02:03 duonghb53

Feel free to give it a go @duonghb53! Let me know if you have any questions on implementation

gjermundgaraba avatar Mar 04 '25 10:03 gjermundgaraba

@gjermundgaraba Yes. I'm going read more and ask later.

duonghb53 avatar Mar 04 '25 10:03 duonghb53

@gjermundgaraba what's branch base to develop?

duonghb53 avatar Mar 04 '25 15:03 duonghb53

From main

gjermundgaraba avatar Mar 04 '25 16:03 gjermundgaraba

Hi @gjermundgaraba I recently reviewed the testing section in module 08-wasm. Do you have any documentation or a discussion thread about removing simapp? I’m unsure about the scope of this issue. Could you please provide more details? Thanks!

duonghb53 avatar Mar 05 '25 15:03 duonghb53

No, but the issue gives a hint: the goal is to remove the need for the 08-wasm tests to have a full simapp. Our other tests manage without it, so the goal here would be to get 08-wasm's tests to the same point.

gjermundgaraba avatar Mar 30 '25 17:03 gjermundgaraba