ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

add height field to gRPC requests

Open noot opened this issue 5 months ago • 1 comments

Description

Adds height field to relevant gRPC requests and latest_height bool to override height and query at the latest height.

Following up to my previous PR #5685 - this came up as an issue again when testing IBC with the hermes relayer, as only proofs at the latest height were returned, but this is not the state root we were expecting to compare against, causing verification errors.

Let me know any thoughts/feedback on this approach, if it looks good I can update the rest of the code.

closes: https://github.com/cosmos/ibc-go/issues/149


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
  • [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • [ ] Code follows the module structure standards and Go style guide.
  • [ ] Wrote unit and integration tests.
  • [ ] Updated relevant documentation (docs/).
  • [ ] Added relevant godoc comments.
  • [ ] Provide a conventional commit message to follow the repository standards.
  • [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • [ ] Re-reviewed Files changed in the GitHub PR explorer.
  • [ ] Review SonarCloud Report in the comment section below once CI passes.

noot avatar Sep 17 '24 19:09 noot