ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Adding updates to composite router and scaffolding for LegacyIBCModule

Open chatton opened this issue 7 months ago • 2 comments

Description

This PR applies some PoC router changes to the feature branch.

The main idea being introduced is the concept of a ClassicIBCModule which will be the same as the IBCModule we have now, and then in a future PR we will strip down the IBCModule to no longer include the handshake fns.

In the channel handshake fns, we will route to the Classic modules, and in Send / Recv etc will will route to the slimmer IBCModule modules.

There is a bit of a hack introduced in the AddRoute function which gradually builds up the LegacyIBCModule based on consecutive calls to AddRoute. I think we should be able to remove this entirely with a single call to AddClassicRoute.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
  • [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • [ ] Code follows the module structure standards and Go style guide.
  • [ ] Wrote unit and integration tests.
  • [ ] Updated relevant documentation (docs/).
  • [ ] Added relevant godoc comments.
  • [ ] Provide a conventional commit message to follow the repository standards.
  • [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • [ ] Re-reviewed Files changed in the GitHub PR explorer.
  • [ ] Review SonarCloud Report in the comment section below once CI passes.

chatton avatar Aug 01 '24 11:08 chatton