ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Supply app version to contract keeper

Open chatton opened this issue 7 months ago • 2 comments

Description

closes: #6977

This PR adds the underlying application version to the callback data and propagates it to the contract keeper interface fns.

Added the backport label since it seems like a valuable feature, happy to remove before merging (and update docs) if there's a good reason not to.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
  • [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • [ ] Code follows the module structure standards and Go style guide.
  • [ ] Wrote unit and integration tests.
  • [ ] Updated relevant documentation (docs/).
  • [ ] Added relevant godoc comments.
  • [ ] Provide a conventional commit message to follow the repository standards.
  • [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • [ ] Re-reviewed Files changed in the GitHub PR explorer.
  • [ ] Review SonarCloud Report in the comment section below once CI passes.

chatton avatar Jul 30 '24 15:07 chatton