ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Decide on validation for merkle path prefix in MsgProvideCounterParty

Open DimitrisJim opened this issue 1 year ago • 1 comments

Raised by Aditya in https://github.com/cosmos/ibc-go/pull/6982#discussion_r1696738107

We should probably validate the merkle path prefix as well. Unclear what exactly we should check yet. Let's make an issue for it so we don't lose track of it.

Will be handled by ibc-go team.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned

DimitrisJim avatar Jul 30 '24 11:07 DimitrisJim

Note that current validation in Counterparty simply asserts that MerklePath is not empty, this is what the validation for connections did previously.

Slapping needs-discussion label on this and if we decide the current check suffices, we can close the issue.

DimitrisJim avatar Aug 01 '24 09:08 DimitrisJim

Well, correct me if I am wrong, but all path elements must be non-empty except the last?

In addition, we could do length restriction on each path element, but it would be arbitrary

colin-axner avatar Aug 13 '24 09:08 colin-axner

Closed by #7193

crodriguezvega avatar Aug 26 '24 07:08 crodriguezvega

This issue was mistakenly reopened during some integration work, so closing again now.

gjermundgaraba avatar May 09 '25 14:05 gjermundgaraba