ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Enable Remainder of E2E tests to use t.Parallel()

Open chatton opened this issue 7 months ago • 0 comments

Summary

This is a tracker issue to keep track of which tests work out of the box by enabling t.Parallel() and which ones might need some refactoring or investigation to makes things work.

I will update the Status of each test to be either PASSES (and include in a PR to enable) or NEEDS FOLLOWUP which will mean the test needs some investigation in order to enable t.Parallel()

Test Name Status Notes
TestAuthzTransferTestSuite PASSES N/A
TestIncentivizedTransferTestSuite PASSES Required some small modifications to ensure relayers each have their own address
TestTransferTestSuiteSendEnabled PASSES Only one test, no need for parallel
TestTransferTestSuiteSendReceive PASSES Only one test, no need for parallel
TestTransferLocalhostTestSuite PASSES Only one test, no need for parallel
TestClientTestSuite NEEDS FOLLOWUP A lot of tests in this suite execute gov proposals, modify params, and update clients and will need to be looked at on a case by case basis to see which ones are safe to run in parallel
TestConnectionTestSuite PASSES Only one test, no need for parallel
TestInterchainAccountsTestSuite NEEDS FOLLOWUP Almost all the tests assume connection-0 and it is hard coded. Also, at the moment packet filtering is applying a generic ica* pattern, and we need to figure out a way to only watch ica channels created in each test
TestInterchainAccountsGovTestSuite PASSES Only one test, no need for parallel
TestGrandpaTestSuite (can we remove?) NEEDS FOLLOWUP Various attempts make gov proposals and attempt to recover clients, some of these can likely go in a parallel test suite, but several may need their own.

NOTE: in order to enable tests in CI, we just need to add to the exclusion list in e2e.yml and and add the test function to the hard coded list in e2e-test-workflow-call.yml


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned

chatton avatar Jul 04 '24 08:07 chatton