ibc-go
ibc-go copied to clipboard
Support arbitrary binaries in E2Es
Summary of Bug
While it is possible to plug in arbitrary binaries into our E2Es, there are a few issues preventing tests from successfully passing when docker containers other than our dev images are passed in.
The following are issues that been seen by myself and @seantking trying to run these tests with a non-simd binary..
- [ ] Remove assumption that
simd
is the binary name here, this originally came from having asimd
and anicad
, we can just check the version directly. - [ ] Stop relying on image tag to determine ibc-go version. This works only for our
simd
test image. We can rely on the tag for our tests, but we can add support for this feature for non ibc-go binaries. We must still use tags as our binary won't have ibc-go as a dependency (as ibc-go is the module itself) - [ ] There seems to be an issue that is not yet fully understood with gov tests, to reproduce, run TestSendEnabledParam with a non simd binary. I suspect it might have something to do with an sdk config being different within the chain binary and within the tests, but this is just a hunch. Further investigation needs to be done to identify the root cause and the fix.
ref: first issue resolved in this branch https://github.com/cosmos/ibc-go/tree/support-arbitrary-binaries-in-e2es
For Admin Use
- [ ] Not duplicate issue
- [ ] Appropriate labels applied
- [ ] Appropriate contributors tagged/assigned