ibc-go
ibc-go copied to clipboard
e2e: add compatibility tests for v7.5.x and v8.3.x
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
- [x] Targeted PR against the correct branch (see CONTRIBUTING.md).
- [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
- [ ] Code follows the module structure standards and Go style guide.
- [ ] Wrote unit and integration tests.
- [ ] Updated relevant documentation (
docs/). - [ ] Added relevant
godoccomments. - [ ] Provide a conventional commit message to follow the repository standards.
- [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
- [ ] Re-reviewed
Files changedin the GitHub PR explorer. - [ ] Review
SonarCloud Reportin the comment section below once CI passes.
Summary by CodeRabbit
- New Features
- Enhanced testing suites to include conditional checks and support for newer chain versions, improving compatibility and functionality across different environments.
- Tests
- Updated and added test cases in testing suites to verify new functionalities based on chain version.
- Chores
- Expanded workflow triggers in GitHub Actions to include additional release versions, ensuring comprehensive testing.
Walkthrough
Walkthrough
The updates aim to enhance the end-to-end testing framework for interchain accounts by introducing new features and version-specific checks. These changes include adding conditions and variables to test suites and adjusting workflow triggers to accommodate additional release versions.
Changes
| File Path | Change Summary |
|---|---|
e2e/tests/interchain_accounts/query_test.go |
Added chainBVersion variable declaration, conditions, and new test blocks based on supported feature releases. Added new variable declarations for icaAck, queryTxResp, and balanceResp. |
e2e/tests/interchain_accounts/params_test.go |
Modified logic in TestHostEnabledParam() to conditionally verify acknowledgement errors in the ack transaction based on transaction event query feature support for a specific chain version. |
Possibly related issues
- cosmos/ibc-go#4173: The changes in this PR align with the objectives to enhance testing coverage and validate the functionality of new queries (like
packet-events) in the e2e test suite. - cosmos/ibc-go#4872: The enhancements in this PR may contribute to automating the generation of compatibility data and improving version-specific testing accuracy as outlined in this issue.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Thank you @crodriguezvega!
should each of these sets of tests also include the opposing release branch, or will we update for example the release/v8.3.x tests to include v7.5.0 wen cut?
Correct, when we cut v7.5.0 I will update the tests in release/v8.3.x to test as well against that tag.
Finally got all the compatibility tests for release/v7.5.x green, so I will merge the PR after CI finishes.
Quality Gate passed for 'ibc-go'
Issues
9 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication