ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Bundle the transition to FLUSHCOMPLETE into a single function

Open colin-axner opened this issue 1 year ago • 2 comments

Summary

When transitioning to FLUSHCOMPLETE, two invariants MUST be true:

  • the counterparty timeout has not elapsed
  • there are no in-flight packets for our end to process

We have verified as the main branch stands today, the implementation is correct. To future proof maintenance, we can make this invariant easier to maintain by bundling these checks and state transitions into a single function. This may require some reworkings of the Ack and Confirm handlers as we currently check the timeout in the handler and perform the state transition in the write function


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned

colin-axner avatar Jan 25 '24 15:01 colin-axner

Can I work on this issue sir ?

hoangdv2429 avatar Feb 08 '24 14:02 hoangdv2429

@hoangdv2429 Sorry for the late reply: yes, you can work on this one. Thank you!

crodriguezvega avatar Mar 17 '24 13:03 crodriguezvega