ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Refactor IBC message handling

Open colin-axner opened this issue 4 years ago • 1 comments

Summary

The message server integration came last minute before the original 0.40.0 rc was cut. This left the IBC code a little bit in a disarray since it integrated the message server without reworking our internals which heavily relied on the previous SDK handler design. We have like 2 layers of redirects right now and structs that are being created and then never used, such as sdk.Result.

This may become problematic since it is hard to understand what each layer is doing here. There should really only be 2 layers, 1 for entry point from the SDK app, the second should be contained in the sub module itself. That is, a create client message, should enter the IBC handler at the top level and then it should go directly to the sub-module message server (02-client/keeper/msg_server.go). The IBC keeper shouldn't house all the message server itself, it doesn't add any benefit.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

colin-axner avatar Jan 21 '21 12:01 colin-axner

Adding self, will address after changes from eureka/port-refactor have settled and ideally will be able to target main.

DimitrisJim avatar Jul 31 '24 13:07 DimitrisJim

Closing this for now. It is a bit outdated and upcoming changes will likely solve the main issue here.

gjermundgaraba avatar May 07 '25 09:05 gjermundgaraba

This issue was mistakenly reopened during some integration work, so closing again now.

gjermundgaraba avatar May 09 '25 13:05 gjermundgaraba