ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Add heights to every gRPC request

Open colin-axner opened this issue 4 years ago • 6 comments

Summary

Heights are not included in gRPC requests as the height can be set in the SDK context. This isn't very useful for non-go implementations which might have a difficult time setting the SDK context correctly.

We should add a height request into the gRPC requests. ibc-rs is currently having difficulty doing gRPC requests at specific heights.

The height in the request seems sufficiently generalized that other implementations could implement the same gRPC routes with the same proto files

cc @fedekunze


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged/assigned

colin-axner avatar Apr 29 '21 12:04 colin-axner

ref

colin-axner avatar Apr 29 '21 12:04 colin-axner

@colin-axner any progress/updates on this? I'm working on integrating IBC in Rust into Astria and have run into this as a major issue, since I would rather use only gRPC requests rather than the ABCI + gRPC combo. I'm happy to take this issue on!

noot avatar Jan 18 '24 17:01 noot

doesn't appear that this was closed due to some blocker so don't see why you couldn't take it on and push it through, rationale still appears to hold :smile:. cc @crodriguezvega for a second opinion.

DimitrisJim avatar Jan 19 '24 07:01 DimitrisJim

No, this hasn't been implemented and there hasn't been any progress, so thanks @noot if you want to work on it. For reference, here's a PR where Colin started to work on this but eventually closed.

crodriguezvega avatar Jan 19 '24 08:01 crodriguezvega

great, thanks @DimitrisJim and @crodriguezvega ! I'll take this on then :)

noot avatar Jan 19 '24 17:01 noot

I am going to tentatively put this in v11...

crodriguezvega avatar Aug 15 '24 15:08 crodriguezvega

I'll close this for now. While this might be useful, it is not going to be prioritized unless there is a clear need for it right now. We can reopen and reconsider in the future if needed.

gjermundgaraba avatar May 25 '25 10:05 gjermundgaraba