iavl icon indicating copy to clipboard operation
iavl copied to clipboard

refactor: use cosmossdk.io/core/log

Open tac0turtle opened this issue 1 year ago • 1 comments

This pr uses cosmossdk.io/core/log instead of cosmossdk.io/log to avoid the import of zero log and implementation specific items.

This is a proposal for dep cleanup

Summary by CodeRabbit

  • Chores
    • Updated logging import paths across various files for better organization.
    • Replaced log.NewTestLogger(t) with log.NewNopLogger() in migrate_test.go for logging consistency.

tac0turtle avatar May 28 '24 11:05 tac0turtle

[!WARNING]

Review Failed

The head commit changed during the review from af8478dbc4bf3636330138e3ac32c246f3a8b99c to 65dd14a41f201ce4c08dac7a4b9fabbb678df61f.

Walkthrough

The changes involve updating the import path for the logging module across multiple files from "cosmossdk.io/log" to "cosmossdk.io/core/log". Additionally, in migrate_test.go, the logger initialization was updated from log.NewTestLogger(t) to log.NewNopLogger(). These changes likely reflect a reorganization of the logging package within the cosmossdk.io library.

Changes

Files Change Summary
basic_test.go, tree_test.go Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log".
benchmarks/bench_test.go, tree_random_test.go Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log".
benchmarks/cosmos-exim/main.go, diff_test.go, immutable_tree.go, import_test.go, iterator_test.go, migrate_test.go, mutable_tree.go, mutable_tree_test.go, nodedb.go, nodedb_test.go, proof_iavl_test.go, proof_ics23_test.go, testutils_test.go Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log".
migrate_test.go Updated import from "cosmossdk.io/log" to "cosmossdk.io/core/log" and changed log.NewTestLogger(t) to log.NewNopLogger().

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

:bangbang: IMPORTANT Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 28 '24 11:05 coderabbitai[bot]