gravity-bridge icon indicating copy to clipboard operation
gravity-bridge copied to clipboard

New validators getting slashed unnecessarily

Open mankenavenkatesh opened this issue 4 years ago • 0 comments

In valset slashing logic,

We look through the currentBondedSet and slash validators who haven't signed a valset that is currentHeight - signedBlocksWindow old

Problem: if i am a new validator who joined at the end of SignedValsetsWindow, i will be slashed and jailed for not confirming the previous validator set which i am not part of.

Also my confirmation doesn't add any value as Peggy contract checks for 2/3+1 confirmations of previous valset request members.

https://github.com/cosmos/gravity-bridge/blob/82dd536d7ce2f7ba5a222eef88a8bd8fab14bd3d/module/x/peggy/abci.go#L40

Suggestion: Instead of checking with currentBondedSet we should check with vs.Members

mankenavenkatesh avatar Feb 21 '21 02:02 mankenavenkatesh