gaia icon indicating copy to clipboard operation
gaia copied to clipboard

chore: adds ohmyzsh plugin for gaiad

Open tokamak-git opened this issue 1 year ago • 3 comments

Description

Closes: #1331

https://github.com/cosmos/gaia/issues/1331

adds ohmyzsh completion script with instructions for gaiad


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [x] Included the correct type prefix in the PR title
  • [x] Targeted the correct branch (see PR Targeting)
  • [x] Provided a link to the relevant issue or specification
  • [x] Reviewed "Files changed" and left comments if necessary
  • [x] Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] Confirmed the correct type prefix in the PR title
  • [ ] Confirmed all author checklist items have been addressed
  • [ ] Confirmed that this PR does not change production code

tokamak-git avatar Dec 14 '23 19:12 tokamak-git

hey @MSalopek , any other changes required to merge this in?

tokamak-git avatar Dec 18 '23 05:12 tokamak-git

1. I don't see any `provider` commands listed in the [completions file](https://github.com/cosmos/gaia/blob/6d65ab17a7a7401a4c5d1427fb545892153df4fa/contrib/shell_completion/_gaiad). Is that by design?

the script is auto-generated thus did not modify it so as to ensure reproducibility.

2. Instructions on how to update the completions when the CLI changes should be provided.
3. I'm assuming the completions were generated? If so, can you provide the generation script?

Have added a command in the MAKEFILE make gen-completion

have also added a github action that runs on main and release branches so as to automate the process of the script creation. Your input on the same would be appreciated.

tokamak-git avatar Dec 18 '23 15:12 tokamak-git

Hey folks. are there any changes you would recommend to this?

tokamak-git avatar Feb 16 '24 15:02 tokamak-git

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 20 '24 00:05 github-actions[bot]