gaia
gaia copied to clipboard
fix(export-genesis): fix export genesis command for missing values
part of #1384
Description
Some values are missing in the genesis JSON when we are exporting it. So we can't validate the genesis after export.
Most of the values should be upgraded based on default genesis parameters, but maybe we should also add the liquidityPoolRecords
parameter from the liquidity module
Codecov Report
Merging #1800 (cbd1656) into main (5e569a1) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head cbd1656 differs from pull request most recent head 40b2b8e. Consider uploading reports for the commit 40b2b8e to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #1800 +/- ##
=======================================
Coverage 43.13% 43.13%
=======================================
Files 15 15
Lines 1340 1340
=======================================
Hits 578 578
Misses 742 742
Partials 20 20
@Pantani @glnro this is not tested via the current tests that we have right? If not, is it practical to add something?
It's strange that Name and Symbol were left empty when the rest was populated.
We should ensure whatever it is it matches https://github.com/cosmos/chain-registry/blob/master/cosmoshub/assetlist.json
They have us listed as
"name": "Cosmos",
"symbol": "ATOM",
Either we update the chain registry or update here so that name = Cosmos
instead of Cosmos Hub Atom
.
I prefer the former since there may be wallets, exchanges or explorers using the chain-registry already.