gaia icon indicating copy to clipboard operation
gaia copied to clipboard

sdk v0.45.8 for gaia v7.0.x

Open faddat opened this issue 1 year ago • 5 comments

This PR upgrades gaia to use cosmos-sdk v0.45.7, which introduces a number of performance improvements originally developed at Osmosis at https://github.com/osmosis-labs/iavl

These improvements were later merged to the upstream iavl, and became iavl v0.19.*

The PR also bumps ibc-go to v3.0.2

This PR requires an upstream merge in the liquidity module.

  • https://github.com/Gravity-Devs/liquidity/pull/21

I'd take this PR out of draft, once we've got upstream patched so that the liqudity module can be a clean import again.

This PR has been tested by running it using the snapshot from:

https://quicksync.io/networks/cosmos.html

faddat avatar Aug 25 '22 18:08 faddat

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/v7.0.x@231ae5e). Click here to learn what that means. The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v7.0.x    #1695   +/-   ##
=================================================
  Coverage                  ?   15.77%           
=================================================
  Files                     ?       10           
  Lines                     ?     1363           
  Branches                  ?        0           
=================================================
  Hits                      ?      215           
  Misses                    ?     1137           
  Partials                  ?       11           

codecov[bot] avatar Aug 25 '22 18:08 codecov[bot]

hi @faddat thanks for this PR! looks like the e2e test is failing, is there a breaking change to the API that isn't being accounted for in the release? seems the error has to do with a config file, were you able to pass E2E tests locally?

okwme avatar Sep 12 '22 09:09 okwme

The liquidity module has new release v1.5.2 that bumped Cosmos SDK to v0.45.8.

jaybxyz avatar Sep 14 '22 05:09 jaybxyz

@crodriguezvega is this the correct version of ibc? ibc 3.2.1 uses cosmos sdk v0.45.8 right?

okwme avatar Sep 16 '22 12:09 okwme

@okwme Yep, it is the correct version of ibc, I had mass confusion on this item, as well, here's the breakdown:

  • On certain starport chains the combo of v0.45.8 and v0.34.21 can cause issues, but only with tests.
  • In the case of Gaia, since we don't want a state breaking change, v3.0.2 for ibc and v0.45.8 for sdk and tendermint v0.34.21 are correct. IBC-go v3.2.0 is a state breaking change.

faddat avatar Sep 17 '22 03:09 faddat

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 02 '22 00:11 github-actions[bot]