gaia icon indicating copy to clipboard operation
gaia copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

CI Nits

Open faddat opened this issue 1 year ago • 2 comments

Summary of Bug

This commit:

https://github.com/cosmos/gaia/commit/76da6d29354be409ac72b0839eeccc488a50014b

Indicates strongly that we've got some CI issues to clean up. Merges to main should never skip any step of CI, and they should always pass all CI checks.

Version

main

Steps to Reproduce

I am not sure (yet)

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
  • [ ] Is a spike necessary to map out how the issue should be approached?

faddat avatar Aug 25 '22 17:08 faddat

hi @faddat thanks for the issue. I'm confused what's going on here. the commit link you give has a failed test but the same commit passes when viewed from the merged PR. i'm not sure if this is a problem with our CI or some kind of bug in github? do you have any insight on what the difference between these two views might be? Screen Shot 2022-09-12 at 11 48 13 Screen Shot 2022-09-12 at 11 46 48

okwme avatar Sep 12 '22 09:09 okwme

@mmulji-ic is adding a daily check to try to make sure these are always passing. we realized it was an external dependency targeting latest that broke main recently and this would highlight that sooner for us.

nondeterminism is run on PRs targeting release** or PRs with the tag sim

we've increased the instances where tests are run based on your previous PRs @faddat , are there other areas you're suggesting we further modify or is the incoming change from @mmulji-ic sound like enough to close this?

okwme avatar Sep 19 '22 15:09 okwme