gaia icon indicating copy to clipboard operation
gaia copied to clipboard

Fix automatic assignee

Open okwme opened this issue 1 year ago • 4 comments

Summary

When creating new issues the gaia repo assigns a bunch of people for code review. I'm afraid this is turning to noise and we're not getting reviews as a result.

Problem Definition

I'm having trouble finding docs that cover this. The only thing I've found is: https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team but it doesn't seem to cover our needs.

Proposal

Figure out why it's assigning who it is and reduce it to a smaller group with higher reliability for reviews


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
  • [ ] Is a spike necessary to map out how the issue should be approached?

okwme avatar Aug 01 '22 15:08 okwme

looks like it's coming from CODEOWNERS.md https://github.com/cosmos/gaia/blob/main/.github/CODEOWNERS and it seems like sam and maria got added for this PR: https://github.com/cosmos/gaia/pull/1616 because they are included for subdirectories of governance.

okwme avatar Aug 01 '22 15:08 okwme

Just manually removed Maria and Sam from that issue in the UI. @okwme looks like you manually added them ... see convo

@okwme okwme requested review from ebuchman, hxrts and mariapao as code owners 23 hours ago

This is the current reviewers list ... can we remove some people who are not actively reviewing?

okwme alexanderbez zmanian yaruwangway jgimeno crodriguezvega cmwaters jackzampolin mmulji-ic glnro

mmulji-ic avatar Aug 02 '22 12:08 mmulji-ic

Implemented in PR #1659

mmulji-ic avatar Aug 09 '22 09:08 mmulji-ic

Close when @LexaMichaelides is added to the Github Hypha team.

mmulji-ic avatar Aug 10 '22 15:08 mmulji-ic