ethermint
ethermint copied to clipboard
compability with ethers.js
Proposal: [Description of the feature]
Acceptance Criteria: resolve issue with safety check so that ethers.js is fully compatible with Ethermint.
currently, ethermint is not compatible with ethers.js due to a safety check. we need to fork ethers to remove this check and ensure that it works as usual. then attempt to get an ethermint compatible version upstreamed
Current behavior: [What currently happens]
Desired behavior: [What you would like to happen]
Use case: [Why is this important (helps with prioritizing requests)]
Requests may be closed if we're not actively planning to work on them.
which is the safety check? I'd prefer to avoid maintaining another fork, so if we can upstream the required changes to ethers.js that would be ideal
@fedekunze I believe it's here: https://github.com/ethers-io/ethers.js/blob/b288ad9ba791073df2768c580abe9173c6b851f6/providers/base-provider.js#L789-L792
yeah, not planning on maintaining our own fork, the goal is to upstream
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.