cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

gentx --name vuser --amount 10000000foo asks for keyring password three times

Open njmurarka opened this issue 4 years ago • 5 comments

I was talking with @alessio today and it was noted that with 0.38.1 of the SDK, if I run gentx (at least with file-based keyring backend), I am asked for the keyring password three times.

This is a bit of a usability problem. I'd suggest there be some documentation about this or it be "resolved". It came across as a concern, as if we were doing something wrong, because of this behaviour.

njmurarka avatar Mar 10 '20 00:03 njmurarka

I suppose we have to trace the execution call stack of this command and see where the passphrase is needed. Having this info, we can update APIs to accept a passphrase instead of asking for it?

alexanderbez avatar Mar 10 '20 01:03 alexanderbez

It's possible already to pass a buffer to keys.NewKeyring() with a passphrase. This is potentially dup of #5403 (gentx shows this behaviour only when with the file backend)

alessio avatar Mar 10 '20 01:03 alessio

This is blocked by post-protobuffer transition related work, i.e. TxBuilder should disapperar soon cc @alexanderbez

alessio avatar Mar 18 '20 18:03 alessio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 05 '20 00:07 github-actions[bot]

I am not able to reproduce this. Is it still happening ? @njmurarka could you let me know if it is still a problem.

rllola avatar Aug 10 '22 11:08 rllola

closing this in favour of https://github.com/cosmos/cosmos-sdk/issues/12901

tac0turtle avatar Aug 15 '22 13:08 tac0turtle