cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

notes for docs from upgrading ibc

Open faddat opened this issue 2 years ago • 5 comments

On a lark, today I tried to just

go get github.com/cosmos/[email protected]

and I really got suprisingly far, so I'm keeping notes here

  • remove github.com/cosmos/cosmos-sdk/client/docs/statik blank import from app.go
  • use cosmossdk.io modules for upgrade,
  • tmservice -> ctmservice
  • remove upgrade/client & calls to the upgrade client's legacy proposal handlers
  • KVStorePrefixIterator, sdk.StoreDecoderRegistry, sdk.NewKVStoreKeys, sdk.NewTransientStoreKeys, sdk.NewMemoryStoreKeys have moved to store types
  • StoreDecoderRegistry has moved to types/simulation
  • DiffKVStores has moved to testutil/sims

Tracking this work in hackmd here:

https://hackmd.io/e2ENN23qTkWFTm_f3NunGw

Please let me know if you'd like access. I wasn't aware that hackmd can be linked to markdown files on github, this is great.

faddat avatar Jun 09 '23 20:06 faddat

Just curious what is this issue about? Do you think it is things we need to add in the UGPRADING.md?

julienrbrt avatar Jun 09 '23 20:06 julienrbrt

I'm messing about with an ibc upgrade, and tracking changes that I make

I'll add more detail and context to the issue (by making a PR) when I've got a better grip on that

Kind of same as before I'm going to try and construct a "featureful" "ideal chain" and use that for integration work

faddat avatar Jun 09 '23 20:06 faddat

Alright, it seemed like an UPGRADING.md, and that file should be the canonical file of what is needed to upgrade to v0.50. If you find something missing, let's add it there. Import changes are mentioned in the changelog only, so it will be normal if you do not find it there. Do note that we haven't completed the work on the upgrading.md, so much can be missing (https://github.com/cosmos/cosmos-sdk/issues/16473) Anyway, awesome that you are already playing with v0.50!!

julienrbrt avatar Jun 09 '23 20:06 julienrbrt

Yep, I figured it wasn't finished, and figured I could lend a hand because I wanna try out some of these new swanky features :)

faddat avatar Jun 09 '23 20:06 faddat

  • https://github.com/cosmos/ibc-go/pull/3808

faddat avatar Jun 09 '23 21:06 faddat