cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

feat: added InConsensus() function to the context

Open chandiniv1 opened this issue 1 year ago • 1 comments

Description

Added Inconsensus() function to the context and changed NewContext to take in OutOfConsensus as a variable ref: #16236

Closes: #16236


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [ ] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [ ] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

chandiniv1 avatar May 23 '23 07:05 chandiniv1

I think theres some misunderstanding of how this is supposed to work

ValarDragon avatar Jun 01 '23 20:06 ValarDragon

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 17 '23 00:08 github-actions[bot]

thank you for the pull request. Reading the comments i believe we should do a short adr or rfc for a quick explanation on the goals and needed requirements. Ill close this pr but would you be open to writing the document

tac0turtle avatar Aug 17 '23 12:08 tac0turtle