cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

1 validator set should use 1 major release of golang

Open faddat opened this issue 3 years ago • 2 comments

Summary of Bug

When validator sets mix go 1.18 and 1.19, bad things seem to happen.

Since some distributions are shipping with go 1.19 and/or people's computers have go1.19, and if we require go 1.19, then validator sets should use it.

Version

any

Steps to Reproduce

have a validator set mix go 1.18 and 1.19 binaries, it seems to lead to apphash errors with the same code.

faddat avatar Nov 22 '22 17:11 faddat

applications can enforce go versions across the chain. I agree there was an issue with go1.18 -> go1.19 but this is also generally seen as a breaking change for node operators and why we have shied away from it in the past

tac0turtle avatar Nov 23 '22 23:11 tac0turtle

This is why I'm offering guidance; really want to make an sdk user guide.

Time is the main issue.

faddat avatar Nov 25 '22 12:11 faddat

From the SDK perspective what were you thinking of?

I don't think we can do much more that adding an advice in the docs.

A small :::warning https://docs.cosmos.network/main/run-node/run-production here should do it right?

julienrbrt avatar Jan 14 '23 23:01 julienrbrt

Thanks so much for finishing the job sir

faddat avatar Jan 26 '23 19:01 faddat