cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

feat: duration renderer for SIGN_MODE_TEXTUAL

Open JimLarson opened this issue 3 years ago • 1 comments

Description

Closes: #12710

Adds SIGN_MODE_TEXTUAL value renderer for google.protobuf.Duration messages.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [X] included the correct type prefix in the PR title
  • [X] added ! to the type prefix if API or client breaking change
  • [X] targeted the correct branch (see PR Targeting)
  • [X] provided a link to the relevant issue or specification
  • [X] followed the guidelines for building modules
  • [X] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [X] included comments for documenting Go code
  • [X] updated the relevant documentation or specification
  • [X] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

(CHANGELOG intentionally unmodified - will be updated with the whole epic)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

JimLarson avatar Sep 16 '22 00:09 JimLarson

This branch is out-of-date with the base branch

@JimLarson Could you rebase/merge main, or give maintainers write access to your branch so that we can do it for you?

amaury1093 avatar Oct 06 '22 10:10 amaury1093

@amaurym or @julienrbrt please reenable the automerge. Thanks!

JimLarson avatar Oct 07 '22 00:10 JimLarson

Codecov Report

Merging #13312 (08731fe) into main (6d03dde) will decrease coverage by 0.08%. The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13312      +/-   ##
==========================================
- Coverage   54.05%   53.97%   -0.09%     
==========================================
  Files         653      648       -5     
  Lines       55899    55425     -474     
==========================================
- Hits        30216    29915     -301     
+ Misses      23269    23111     -158     
+ Partials     2414     2399      -15     
Impacted Files Coverage Δ
tx/textual/valuerenderer/duration.go 78.40% <78.40%> (ø)
tx/textual/valuerenderer/valuerenderer.go 79.59% <100.00%> (ø)
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) :arrow_down:
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) :arrow_down:
cosmovisor/cmd/cosmovisor/help.go
cosmovisor/cmd/cosmovisor/run.go
cosmovisor/logger.go
cosmovisor/errors/multi.go
cosmovisor/cmd/cosmovisor/version.go
cosmovisor/cmd/cosmovisor/main.go
... and 12 more

codecov[bot] avatar Oct 07 '22 00:10 codecov[bot]