cosmos-sdk
cosmos-sdk copied to clipboard
fix linting issues exposed by fixing golangci-lint
This PR fixes linting issues that were exposed by fixing golangci-lint
- [ ] included the correct type prefix in the PR title
- [ ] added
!
to the type prefix if API or client breaking change - [ ] targeted the correct branch (see PR Targeting)
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for building modules
- [ ] included the necessary unit and integration tests
- [ ] added a changelog entry to
CHANGELOG.md
- [ ] included comments for documenting Go code
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
- [ ] confirmed the correct type prefix in the PR title
- [ ] confirmed
!
in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Codecov Report
Merging #12895 (c74fee6) into main (15b04c2) will increase coverage by
2.21%
. The diff coverage is71.87%
.
@@ Coverage Diff @@
## main #12895 +/- ##
==========================================
+ Coverage 55.87% 58.09% +2.21%
==========================================
Files 650 734 +84
Lines 55008 62695 +7687
==========================================
+ Hits 30737 36424 +5687
- Misses 21807 23302 +1495
- Partials 2464 2969 +505
Impacted Files | Coverage Δ | |
---|---|---|
baseapp/baseapp.go | 76.87% <ø> (ø) |
|
baseapp/msg_service_router.go | 80.88% <ø> (ø) |
|
client/keys/add.go | 63.34% <ø> (ø) |
|
codec/amino_codec.go | 100.00% <ø> (ø) |
|
codec/proto_codec.go | 61.31% <ø> (ø) |
|
crypto/hd/hdpath.go | 98.40% <ø> (ø) |
|
crypto/keys/multisig/codec.go | 100.00% <ø> (ø) |
|
crypto/keys/secp256k1/secp256k1.go | 88.63% <ø> (ø) |
|
crypto/keys/secp256k1/secp256k1_nocgo.go | 83.33% <ø> (ø) |
|
depinject/config.go | 85.88% <ø> (ø) |
|
... and 176 more |
Thanks @faddat!