cosmos-sdk
cosmos-sdk copied to clipboard
refactor!: Remove proposer-based rewards
Description
Remove base and bonus proposer rewards from the x/distribution mechanism.
Changelog
- Deprecate base and bonus reward fields in
Params
- Bump
x/distribution
consensus version to 4 - Refactor
Keeper#AllocateTokens
to no longer distribute a base and bonus to validators
closes: #12667 closes: #9161
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
- [ ] included the correct type prefix in the PR title
- [ ] added
!
to the type prefix if API or client breaking change - [ ] targeted the correct branch (see PR Targeting)
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for building modules
- [ ] included the necessary unit and integration tests
- [ ] added a changelog entry to
CHANGELOG.md
- [ ] included comments for documenting Go code
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
- [ ] confirmed the correct type prefix in the PR title
- [ ] confirmed
!
in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
this makes sense
Related: #9161
Codecov Report
Merging #12876 (ff55412) into main (fabf739) will decrease coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #12876 +/- ##
==========================================
- Coverage 55.75% 55.70% -0.06%
==========================================
Files 650 646 -4
Lines 55011 54855 -156
==========================================
- Hits 30674 30558 -116
+ Misses 21877 21844 -33
+ Partials 2460 2453 -7
Impacted Files | Coverage Δ | |
---|---|---|
x/distribution/keeper/params.go | 75.00% <ø> (-3.58%) |
:arrow_down: |
x/distribution/module.go | 64.28% <ø> (ø) |
|
x/distribution/abci.go | 100.00% <100.00%> (ø) |
|
x/distribution/keeper/allocation.go | 97.10% <100.00%> (+10.43%) |
:arrow_up: |
x/distribution/keeper/store.go | 51.25% <0.00%> (-2.50%) |
:arrow_down: |
x/distribution/keeper/keeper.go | 79.62% <0.00%> (-1.86%) |
:arrow_down: |
tx/textual/valuerenderer/valuerenderer.go | ||
tx/textual/valuerenderer/bytes.go | ||
tx/textual/valuerenderer/int.go | ||
... and 2 more |
Can we delete that test now: https://github.com/cosmos/cosmos-sdk/commit/8b32094d1b4c320304bdb760604b662bb0c41e58?