cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

Diff Action

Open faddat opened this issue 2 years ago • 1 comments

Summary of Bug

Our usage of the diff action allows things to slip through the cracks.

Changing code in one piece of the SDK can cause flaws in another piece of the SDK.

The diff action is looking for diffs in specific modules, but we have a set of interdependent modules.

Version

All

Steps to Reproduce

See PR's:

  • #12842
  • #12865
  • #12867
  • #12866

Basically if we pick through the CI output, what we find is that snapshots get a different hash with go 1.19 -- OR io/ioutil isn't exactly matched by its replacements in io and os, and so snapshots get a different hash.

This is not reflected in the CI output for "main". The tests did not run.

Suggested solution

Discontinue use of the diff action, so that we run ci on all the things with each commit. I don't think this is any more time consuming than either e2e or codeql, neither of which we should drop. Since this is a CI issue, I'll make a PR to test this, feel free to reject if you'd like.

faddat avatar Aug 09 '22 10:08 faddat

the Diff action checks if there is a go file change, if so it tests all modules not only the changed one. I don't see where the problem is

tac0turtle avatar Aug 09 '22 11:08 tac0turtle

ah, well, I think we found the problem: golangci-lint always passsed because we did not check out the code. Then this was copy pasted into gaia.

faddat avatar Aug 16 '22 09:08 faddat