refactor!: Refactor CommunityPoolSpendProposal

[alexanderbez]

Description

This PR introduces the ability for v1 x/gov to execute a message that directly spends tokens from the community pool opposed to having to execute the legacy CommunityPoolSpendProposal proposal.

This provides the ability for governance to spend tokens from the community pool, either to itself (x/gov module account) or to another account.

Changelog

• Deprecate CommunityPoolSpendProposal
• Create MsgCommunityPoolSpend with x/gov as the authority (by default)
• Remove x/gov from SimApps's x/bank deny list (so it can directly received funds)

ref: https://github.com/cosmos/cosmos-sdk/pull/12831#issuecomment-1208207410 closes: https://github.com/cosmos/cosmos-sdk/issues/12098

cc @hxrts @nooomski

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

• [ ] included the correct type prefix in the PR title
• [ ] added ! to the type prefix if API or client breaking change
• [ ] targeted the correct branch (see PR Targeting)
• [ ] provided a link to the relevant issue or specification
• [ ] followed the guidelines for building modules
• [ ] included the necessary unit and integration tests
• [ ] added a changelog entry to CHANGELOG.md
• [ ] included comments for documenting Go code
• [ ] updated the relevant documentation or specification
• [ ] reviewed "Files changed" and left comments if necessary
• [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• [ ] confirmed the correct type prefix in the PR title
• [ ] confirmed ! in the type prefix if API or client breaking change
• [ ] confirmed all author checklist items have been addressed
• [ ] reviewed state machine logic
• [ ] reviewed API design and naming
• [ ] reviewed documentation is accurate
• [ ] reviewed tests and test coverage
• [ ] manually tested (if applicable)

[codecov[bot]]

Codecov Report

Merging #12852 (4e5681a) into main (4fe7797) will decrease coverage by 0.17%. The diff coverage is 61.44%.

:exclamation: Current head 4e5681a differs from pull request most recent head e50e7c0. Consider uploading reports for the commit e50e7c0 to get more accurate results

@@            Coverage Diff             @@
##             main   #12852      +/-   ##
==========================================
- Coverage   55.87%   55.70%   -0.18%     
==========================================
  Files         646      648       +2     
  Lines       54895    54940      +45     
==========================================
- Hits        30675    30606      -69     
- Misses      21762    21863     +101     
- Partials     2458     2471      +13     

Impacted Files	Coverage Δ
baseapp/abci.go	64.09% <0.00%> (-0.33%)	:arrow_down:
client/flags/flags.go	19.35% <0.00%> (-0.32%)	:arrow_down:
client/rpc/status.go	66.66% <ø> (ø)
client/utils.go	34.92% <0.00%> (ø)
server/rosetta/client_online.go	1.35% <0.00%> (ø)
server/swagger.go	0.00% <0.00%> (ø)
simapp/app.go	82.66% <0.00%> (+3.55%)	:arrow_up:
testutil/list.go	0.00% <0.00%> (ø)
types/result.go	76.74% <ø> (ø)
x/auth/tx/query.go	0.00% <ø> (ø)
... and 62 more

[alexanderbez]

@hxrts @nooomski would you folks mind taking a look at the high-level approach here and if you think it would suite the needs you're looking to solve re gov and community pool?

[alexanderbez]

I received approval from @hxrts and @nooomski. So will resolve conflicts and merge.